Remove deprecation warning to change "tests:" config to "data_tests:" #10670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10670 +/- ##
==========================================
- Coverage 88.94% 88.90% -0.04%
==========================================
Files 180 180
Lines 22798 22784 -14
==========================================
- Hits 20277 20256 -21
- Misses 2521 2528 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MichelleArk
reviewed
Sep 5, 2024
| @@ -388,6 +388,9 @@ def message(self) -> str: | |||
| return line_wrap_message(warning_tag(f"Deprecated functionality\n\n{description}")) | |||
|
|
|||
|
|
|||
| # Note: this deprecation has been removed, but we are leaving | |||
| # the event class here, because users may have specified it in | |||
| # warn_error_options. | |||
MichelleArk
approved these changes
Sep 6, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10564
Problem
The decision was made that we are not deprecating the "tests:" config and it will not be removed in the future, so issuing a deprecation warning is no longer functional.
Solution
Remove the code that issues the warning.
Checklist